Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5510] Add provide context #6137

Closed
wants to merge 1 commit into from
Closed

[AIRFLOW-5510] Add provide context #6137

wants to merge 1 commit into from

Conversation

brunolucatto
Copy link

@brunolucatto brunolucatto commented Sep 17, 2019

Add provide context in order to make kwargs in run_this_func receive the message passed from the controller dag

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Add provide context in order to make kwargs in run_this_func receive the message passed from the controller dag
@kaxil kaxil requested a review from Fokko September 17, 2019 19:05
@kaxil
Copy link
Member

kaxil commented Sep 17, 2019

This has been intentionally removed by some awesome work from @Fokko #5990

@kaxil kaxil closed this Sep 17, 2019
@brunolucatto brunolucatto deleted the patch-2 branch September 17, 2019 19:31
@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #6137 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6137   +/-   ##
=======================================
  Coverage   80.03%   80.03%           
=======================================
  Files         607      607           
  Lines       35019    35019           
=======================================
  Hits        28029    28029           
  Misses       6990     6990
Impacted Files Coverage Δ
airflow/example_dags/example_trigger_target_dag.py 92.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8e18a...4969533. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants