Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Fix incorrect backticks in BREEZE.rst #6161

Merged
merged 1 commit into from
Sep 21, 2019

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Sep 21, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    Doc change

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Fix incorrect backticks in BREEZE.rst

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Doc change

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@kaxil kaxil requested a review from potiuk September 21, 2019 02:13
@codecov-io
Copy link

Codecov Report

Merging #6161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6161   +/-   ##
=======================================
  Coverage   80.09%   80.09%           
=======================================
  Files         606      606           
  Lines       35039    35039           
=======================================
  Hits        28065    28065           
  Misses       6974     6974

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155adf4...17f21d4. Read the comment docs.

@XD-DENG XD-DENG merged commit e68d92f into apache:master Sep 21, 2019
@potiuk
Copy link
Member

potiuk commented Sep 21, 2019

👍

potiuk pushed a commit that referenced this pull request Sep 22, 2019
ashb pushed a commit that referenced this pull request Sep 24, 2019
@kaxil kaxil deleted the fix-incorrect-backticks branch November 29, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants