Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5626] Add labels to MLEngine resources #6296

Merged
merged 1 commit into from Oct 14, 2019

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Oct 9, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5626
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Oct 9, 2019
@mik-laj mik-laj changed the title [AIRFLOW-5626][depends on AIRFLOW-5617,AIRFLOW-5624,AIRFLOW-5625] Add labels to MLEngine resources [AIRFLOW-5626][depends on AIRFLOW-5624,AIRFLOW-5625] Add labels to MLEngine resources Oct 11, 2019
@mik-laj mik-laj changed the title [AIRFLOW-5626][depends on AIRFLOW-5624,AIRFLOW-5625] Add labels to MLEngine resources [AIRFLOW-5626] Add labels to MLEngine resources Oct 13, 2019
@codecov-io
Copy link

Codecov Report

Merging #6296 into master will decrease coverage by 0.95%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6296      +/-   ##
==========================================
- Coverage   80.34%   79.39%   -0.96%     
==========================================
  Files         616      616              
  Lines       35733    36173     +440     
==========================================
+ Hits        28711    28719       +8     
- Misses       7022     7454     +432
Impacted Files Coverage Δ
airflow/gcp/hooks/mlengine.py 52.69% <80%> (-30.01%) ⬇️
airflow/gcp/operators/mlengine.py 52.78% <0%> (-36.73%) ⬇️
airflow/gcp/operators/bigquery.py 62.29% <0%> (-24.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d98a7...9d3bed5. Read the comment docs.

@potiuk potiuk merged commit 13acdd1 into apache:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants