Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4965] Handle quote exceptions in GCP AI operators (v1.10) #6304

Merged
merged 4 commits into from Oct 13, 2019

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Oct 11, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-4965
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Oct 12, 2019
@codecov-io
Copy link

Codecov Report

Merging #6304 into v1-10-test will decrease coverage by 0.05%.
The diff coverage is 97.5%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v1-10-test    #6304      +/-   ##
==============================================
- Coverage       76.67%   76.62%   -0.06%     
==============================================
  Files             509      509              
  Lines           34381    34519     +138     
==============================================
+ Hits            26362    26449      +87     
- Misses           8019     8070      +51
Impacted Files Coverage Δ
airflow/contrib/hooks/gcp_speech_to_text_hook.py 81.25% <100%> (+1.25%) ⬆️
airflow/contrib/hooks/gcp_natural_language_hook.py 92.5% <100%> (+1.32%) ⬆️
airflow/contrib/hooks/gcp_translate_hook.py 71.42% <100%> (+2.19%) ⬆️
airflow/contrib/hooks/gcp_text_to_speech_hook.py 80% <100%> (+1.42%) ⬆️
...rflow/contrib/hooks/gcp_video_intelligence_hook.py 71.42% <100%> (+2.19%) ⬆️
airflow/contrib/hooks/gcp_vision_hook.py 91.98% <100%> (+0.2%) ⬆️
airflow/contrib/hooks/gcp_api_base_hook.py 86.71% <95.83%> (+1.67%) ⬆️
airflow/jobs/local_task_job.py 85.71% <0%> (-4.77%) ⬇️
airflow/contrib/executors/kubernetes_executor.py 63.08% <0%> (-2.92%) ⬇️
airflow/utils/dag_processing.py 57.14% <0%> (-0.18%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf0f30...fe8a0c1. Read the comment docs.

@potiuk potiuk merged commit e38c3ad into apache:v1-10-test Oct 13, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Oct 14, 2019
…pache#6304)

* [AIRFLOW-4965] Handle quote exceptions in GCP operators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants