Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5634] Don't allow disabled fields to be edited in DagModelView #6307

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

ashb
Copy link
Member

@ashb ashb commented Oct 11, 2019

Make sure you have checked all steps below.

Jira

Description

  • If someone plays silly games and edits the HTML (or crafts a request) to
    the DAG model it is possible to edit fields that aren't meant to be
    edited, leading to odd to debug behaviour

    Against v1-10-stable as this only applies to the classic UI. Separate PR coming for RBAC UI (where I will just disable the ability to edit the DagModel. I could do the same here )

Tests

  • Tests added

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

If someone plays silly games and edits the HTML (or crafts a request) to
the DAG model it is possible to edit fields that aren't meant to be
edited, leading to odd to debug behaviour
@ashb ashb requested a review from kaxil October 11, 2019 09:28
@codecov-io
Copy link

Codecov Report

Merging #6307 into v1-10-stable will decrease coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@               Coverage Diff                @@
##           v1-10-stable    #6307      +/-   ##
================================================
- Coverage         76.67%   76.66%   -0.01%     
================================================
  Files               509      509              
  Lines             34381    34389       +8     
================================================
+ Hits              26362    26366       +4     
- Misses             8019     8023       +4
Impacted Files Coverage Δ
airflow/www/views.py 45.1% <88.88%> (+0.31%) ⬆️
airflow/jobs/local_task_job.py 85.71% <0%> (-4.77%) ⬇️
airflow/utils/dag_processing.py 57.14% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf0f30...0642c13. Read the comment docs.

@ashb ashb merged commit 2599cda into apache:v1-10-stable Oct 11, 2019
@ashb ashb deleted the dagmodelview-disabled-fields branch October 11, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants