Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5073] Change SQLSensor to optionally treat NULL as keep poking #6336

Merged
merged 13 commits into from Oct 24, 2019

Conversation

uncletoxa
Copy link
Contributor

Fixing bug treating "NULL" as NULL in sql sensor.

Jira

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

Change SQL sensor to exclude NULL result from success criteria. Remove
allow_null parameter from sensor to avoid extra clutter.
airflow/sensors/sql_sensor.py Outdated Show resolved Hide resolved
airflow/sensors/sql_sensor.py Outdated Show resolved Hide resolved
@uncletoxa
Copy link
Contributor Author

bump
Looks like CI issues does not belong to my PR

@OmerJog
Copy link
Contributor

OmerJog commented Oct 23, 2019

@ashb tests were restarted.. It's ok now

@ashb ashb merged commit 6ba5442 into apache:master Oct 24, 2019
ashb pushed a commit that referenced this pull request Oct 24, 2019
ashb pushed a commit that referenced this pull request Oct 25, 2019
potiuk pushed a commit that referenced this pull request Nov 12, 2019
eladkal pushed a commit to eladkal/airflow that referenced this pull request Dec 2, 2019
kaxil pushed a commit that referenced this pull request Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants