-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5073] Change SQLSensor to optionally treat NULL as keep poking #6336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parameter to decrease clutter.
Co-Authored-By: Ash Berlin-Taylor <ash_github@firemirror.com>
Change SQLSensor to treat NULL as fail. Add boolean allow_null parameter to support legacy behavior passing NULL as success.
6 tasks
Change SQL sensor to exclude NULL result from success criteria. Remove allow_null parameter from sensor to avoid extra clutter.
ashb
reviewed
Oct 16, 2019
ashb
reviewed
Oct 16, 2019
bump |
@ashb tests were restarted.. It's ok now |
eladkal
pushed a commit
to eladkal/airflow
that referenced
this pull request
Dec 2, 2019
…ng (apache#6336) (cherry picked from commit 6ba5442)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug treating
"NULL"
asNULL
in sql sensor.Jira
Description
Tests
Commits
Documentation
Code Quality
flake8