Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5661] Fix create_cluster method of GKEClusterHook #6339

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

turbaszek
Copy link
Member

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    This PR fixes create_cluster method of GKEClusterHook. The method uses get_cluster which already returns a string, so calling self_link once more rises error.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Oct 17, 2019
@turbaszek
Copy link
Member Author

@mik-laj can you tak a look?

@mik-laj mik-laj self-requested a review October 21, 2019 15:15
@mik-laj
Copy link
Member

mik-laj commented Oct 21, 2019

Everything works as expected
Screenshot 2019-10-21 at 17 37 48

@mik-laj mik-laj merged commit e344f61 into apache:master Oct 21, 2019
@turbaszek turbaszek deleted the fix-gke-hook branch December 4, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants