Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5694] Check for blinker in Sentry setup #6365

Merged
merged 1 commit into from Oct 20, 2019

Conversation

marcusianlevine
Copy link
Contributor

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

In order to avoid setting up Sentry when sentry-sdk is installed but not blinker, we import an unused module from blinker so that the ImportError catch will trigger and use the DummySentry instead

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Prevents a known edge case

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

codecov-io commented Oct 19, 2019

Codecov Report

Merging #6365 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6365      +/-   ##
=========================================
+ Coverage   80.09%   80.1%   +<.01%     
=========================================
  Files         616     616              
  Lines       35804   35805       +1     
=========================================
+ Hits        28679   28680       +1     
  Misses       7125    7125
Impacted Files Coverage Δ
airflow/sentry.py 89.04% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c0263...7fd39cf. Read the comment docs.

@potiuk potiuk merged commit c72c427 into apache:master Oct 20, 2019
potiuk pushed a commit that referenced this pull request Oct 20, 2019
kaxil pushed a commit that referenced this pull request Oct 22, 2019
ashb pushed a commit that referenced this pull request Oct 25, 2019
potiuk pushed a commit that referenced this pull request Nov 12, 2019
eladkal pushed a commit to eladkal/airflow that referenced this pull request Dec 2, 2019
kaxil pushed a commit that referenced this pull request Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants