Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6311] Remove python2 from codebase #6860

Merged
merged 1 commit into from
Dec 21, 2019

Conversation

xinbinhuang
Copy link
Contributor

Make sure you have checked all steps below.

Jira

Description

@potiuk
Copy link
Member

potiuk commented Dec 20, 2019

Hey @xinbinhuang - I think that's going in the right direction but:

  • some unit tests are failing
  • it is backwards incompatible change so it requires note In UPDATING.md

@ashb
Copy link
Member

ashb commented Dec 20, 2019

This is mostly about changing the default interpreter in GCP operators more than anything (as we've already removed most of the Py2 specific code elsewhere) so this PR title would be better updated to reflect that (PR titles go in to the changelog)

@xinbinhuang
Copy link
Contributor Author

xinbinhuang commented Dec 20, 2019

some unit tests are failing

Sorry,I was making the changes on another PC that I thought have pre-commit hooks installed while did not . I will double-check that.

This is mostly about changing the default interpreter in GCP operators more than anything (as we've already removed most of the Py2 specific code elsewhere) so this PR title would be better updated to reflect that (PR titles go in to the changelog)

@potiuk @ashb I agree with your opinions. I will create another PR to just include the dataflow changes. while this remains simple as removing those 2lines in the settings.py

@xinbinhuang
Copy link
Contributor Author

Rebased & Remove changes for Dataflow. Will create a separate PR later and link to this one

@codecov-io
Copy link

Codecov Report

Merging #6860 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6860      +/-   ##
==========================================
- Coverage   84.56%   84.28%   -0.29%     
==========================================
  Files         680      680              
  Lines       38454    38453       -1     
==========================================
- Hits        32520    32409     -111     
- Misses       5934     6044     +110
Impacted Files Coverage Δ
airflow/settings.py 93.66% <ø> (-0.05%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c11e4...5c76741. Read the comment docs.

@potiuk potiuk merged commit 6a5a4ef into apache:master Dec 21, 2019
@potiuk
Copy link
Member

potiuk commented Dec 21, 2019

I merged and updated the commit subject slightly.

@xinbinhuang
Copy link
Contributor Author

Thanks! @potiuk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants