[AIRFLOW-6111] [AIP-21] Rename GCP spanner operator and hook #7004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7004 +/- ##
==========================================
- Coverage 85.15% 84.88% -0.28%
==========================================
Files 680 680
Lines 38824 38848 +24
==========================================
- Hits 33061 32975 -86
- Misses 5763 5873 +110
Continue to review full report at Codecov.
|
turbaszek
requested changes
Jan 3, 2020
UPDATING.md
Outdated
| |airflow.contrib.operators.gcp_natural_language_operator.CloudLanguageAnalyzeEntitiesOperator |airflow.providers.google.cloud.operators.natural_language.CloudLanguageAnalyzeEntitiesOperator | | ||
| |airflow.contrib.operators.gcp_natural_language_operator.CloudLanguageAnalyzeEntitySentimentOperator |airflow.providers.google.cloud.operators.natural_language.CloudLanguageAnalyzeEntitySentimentOperator | | ||
| |airflow.contrib.operators.gcp_natural_language_operator.CloudLanguageAnalyzeSentimentOperator |airflow.providers.google.cloud.operators.natural_language.CloudLanguageAnalyzeSentimentOperator | | ||
| |airflow.contrib.operators.gcp_natural_language_operator.CloudLanguageClassifyTextOperator |airflow.providers.google.cloud.operators.natural_language.CloudLanguageClassifyTextOperator | |
There was a problem hiding this comment.
I think this are unrelated changes?
There was a problem hiding this comment.
What about new paths?
There was a problem hiding this comment.
Yeah, but this changes CloudLanguage and the PR says Spanner 💃
There was a problem hiding this comment.
Ops... Fix is on the way.
michalslowikowski00
force-pushed
the
AIRFLOW-6111-Rename-spanner-service
branch
2 times, most recently
from
278644e
to
06f5993
Compare
michalslowikowski00
changed the title
michalslowikowski00
force-pushed
the
AIRFLOW-6111-Rename-spanner-service
branch
from
06f5993
to
fccc34d
Compare
michalslowikowski00
force-pushed
the
AIRFLOW-6111-Rename-spanner-service
branch
from
fccc34d
to
033efd0
Compare
turbaszek
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains changes regarding AIP-21 (renaming GCP operators and hooks):
renamed GCP modules
adde deprecation warnings to the contrib modules
fixed tests
updated UPDATING.md
[AIRFLOW-XXXX]for document-only changesIn case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.