Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6485] BigQuery hook - add missing tests #7077

Conversation

TobKed
Copy link
Contributor

@TobKed TobKed commented Jan 6, 2020

…r methods
for BIgQueryBaseCursor

Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6485

  • Description above provides context of the change
  • Commit message starts with [AIRFLOW-NNNN], where AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

(*) For document-only changes, no JIRA issue is needed. Commit message starts [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Jan 6, 2020
@potiuk
Copy link
Member

potiuk commented Jan 6, 2020

Some problem detected by mergable {AIRFLOW rather than [AIRFLOW

@TobKed TobKed force-pushed the refactor-bq/hook-tests/add-missing-tests branch from 460d924 to ecbed48 Compare January 6, 2020 12:09
@TobKed TobKed force-pushed the refactor-bq/hook-tests/add-missing-tests branch from ecbed48 to 3e36c90 Compare January 6, 2020 12:11
@TobKed TobKed changed the title {AIRFLOW-6485] BigQuery hook - add missing tests [AIRFLOW-6485] BigQuery hook - add missing tests Jan 6, 2020
@TobKed
Copy link
Contributor Author

TobKed commented Jan 6, 2020

@potiuk thanks for pointing this out, I've fixed it.

@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #7077 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7077      +/-   ##
==========================================
- Coverage   85.01%   84.78%   -0.24%     
==========================================
  Files         680      680              
  Lines       38753    38753              
==========================================
- Hits        32945    32855      -90     
- Misses       5808     5898      +90
Impacted Files Coverage Δ
airflow/operators/postgres_operator.py 100% <0%> (ø) ⬆️
airflow/operators/mysql_operator.py 100% <0%> (ø) ⬆️
airflow/operators/mysql_to_hive.py 100% <0%> (ø) ⬆️
airflow/operators/generic_transfer.py 100% <0%> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/executors/celery_executor.py 88.43% <0%> (ø) ⬆️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8373907...3e36c90. Read the comment docs.

@potiuk potiuk merged commit 6cbedf8 into apache:master Jan 6, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants