Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls #7089

Merged
merged 4 commits into from
Jan 9, 2020

Conversation

tooptoop4
Copy link
Contributor

@tooptoop4 tooptoop4 commented Jan 7, 2020


Issue link: AIRFLOW-6452

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:Scheduler Scheduler or dag parsing Issues label Jan 7, 2020
@tooptoop4
Copy link
Contributor Author

before this PR it had 2 sleeps (no need!), it seems the one I removed was there before the processor_poll_interval sleep was added.

@codecov-io
Copy link

codecov-io commented Jan 7, 2020

Codecov Report

Merging #7089 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7089      +/-   ##
=========================================
- Coverage   85.07%   84.8%   -0.28%     
=========================================
  Files         680     680              
  Lines       38810   38802       -8     
=========================================
- Hits        33019   32905     -114     
- Misses       5791    5897     +106
Impacted Files Coverage Δ
airflow/jobs/scheduler_job.py 89.29% <ø> (+0.45%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf3c4b3...1273612. Read the comment docs.

@tooptoop4
Copy link
Contributor Author

@nuclearpinguin pls merge

@turbaszek turbaszek merged commit 70af358 into apache:master Jan 9, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
…lls (apache#7089)

no need for 2 sleep, _processor_poll_interval will already sleep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler Scheduler or dag parsing Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants