Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5974] AIP-21 Change import paths for celery modules #7167

Closed
wants to merge 1 commit into from

Conversation

yqian1991
Copy link

@yqian1991 yqian1991 commented Jan 14, 2020

part of AIP-21, Change import paths for celery modules

Issue link: AIRFLOW-5974

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@yqian1991 yqian1991 force-pushed the AIRFLOW-5974 branch 4 times, most recently from 886189e to 0a878d7 Compare January 15, 2020 23:07
@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #7167 into master will increase coverage by 0.59%.
The diff coverage is 71.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7167      +/-   ##
==========================================
+ Coverage   84.91%   85.51%   +0.59%     
==========================================
  Files         723      759      +36     
  Lines       39546    39936     +390     
==========================================
+ Hits        33581    34150     +569     
+ Misses       5965     5786     -179
Impacted Files Coverage Δ
airflow/contrib/sensors/celery_queue_sensor.py 0% <0%> (-82.15%) ⬇️
airflow/providers/celery/sensors/celery.py 82.14% <82.14%> (ø)
...rflow/contrib/sensors/sagemaker_training_sensor.py 0% <0%> (-100%) ⬇️
airflow/api/client/local_client.py 92% <0%> (-8%) ⬇️
airflow/api/client/api_client.py 63.15% <0%> (-1.55%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 97.64% <0%> (-1.15%) ⬇️
airflow/gcp/hooks/dataflow.py 88.37% <0%> (-0.92%) ⬇️
airflow/operators/python_operator.py 95.13% <0%> (-0.67%) ⬇️
airflow/cli/commands/dag_command.py 85.9% <0%> (-0.31%) ⬇️
airflow/contrib/sensors/emr_base_sensor.py 100% <0%> (ø) ⬆️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c8a82...b94c003. Read the comment docs.

@yqian1991
Copy link
Author

yqian1991 commented Jan 21, 2020

Closing this, seems like a duplicate work of another pr

@yqian1991 yqian1991 closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants