Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXXX] - add communication chapter to contributing #7204

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 18, 2020

Communication


Issue link: Document only change, no JIRA issue

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@potiuk potiuk force-pushed the AIRFLOW-XXXX-add-communication-chapter-to-contributing branch 3 times, most recently from 7ea5179 to 2d84295 Compare January 18, 2020 21:55
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@turbaszek
Copy link
Member

Hey @mschickensoup, would you like to take a look? 😺

@potiuk potiuk force-pushed the AIRFLOW-XXXX-add-communication-chapter-to-contributing branch from f496cbc to 367833f Compare January 20, 2020 12:46
Copy link
Contributor

@mschickensoup mschickensoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this text! I think it's super important for anyone who'd like to join Apache Airflow community. I've left my comments but I also have a general feedback. First of all, I'd focus on a perspective of a total newbie. I had an impression that not everyone might be familiar with Slack / devlist etc. What is missing (not in the text itself) but within the community are rules / good practices on how to e.g. open subjects on the devlist / how to assign them to a certain category/classification [DISCUSSION] etc. or there are such rules but I didn't find them. Not sure. I think it's also worth mentioning how much fun it brings if you communicate with the others. It's not just distributed teams but you actually can meet other contributors live on various events and speaking to them would not be as scary when you have already communicated with them within community 😄I know the whole text is about "How to communicate" inside the community. However, I'd add something like (it's a thought, not the real sentence I'd use) "we are humans, fun individuals who except for being active on the devlist can be met on various meetups/events/local communities". Plus, there is nothing on how to communicate if you're not a developer but you want to be a part of the community too. If there was no Aizhamal, I wouldn't know that I could communicate/be a part of the team and do some good as well :-) I think it's important to also highlight the work of people who make sure that things are ordered, that there are meetups across the world and who take care of clear/proper communication on a daily basis if others forget about it. I guess I did some huge off-top now but I had to speak my mind. Hope you'll find my comments useful.

CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@potiuk potiuk force-pushed the AIRFLOW-XXXX-add-communication-chapter-to-contributing branch from 367833f to f2bd780 Compare February 18, 2020 00:23
Copy link
Member Author

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All updated Any more comments? @nuclearpinguin @mik-laj ?

@potiuk
Copy link
Member Author

potiuk commented Feb 18, 2020

thanks @mschickensoup for comments

@potiuk potiuk merged commit 3f25ff9 into apache:master Feb 18, 2020
potiuk added a commit that referenced this pull request Feb 19, 2020
kaxil pushed a commit that referenced this pull request Feb 21, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil pushed a commit that referenced this pull request Mar 19, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants