[AIRFLOW-6638] Remove flakiness test from test_serialized_db remove #7258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing randomly because it returned the DAGs in random order and sometimes it failed because test_serialized_dag was removing only one file from the list of files but the file could be repeated in case a dag file had more than one DAG defined.
potiuk
force-pushed
the
AIRFLOW-6638-remove-flakiness
branch
from
2a082c1
to
05e2234
Compare
kaxil
approved these changes
Jan 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #7258 +/- ##
==========================================
- Coverage 85.33% 85.05% -0.28%
==========================================
Files 791 791
Lines 40137 40137
==========================================
- Hits 34252 34140 -112
- Misses 5885 5997 +112
Continue to review full report at Codecov.
|
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
…pache#7258) The test was failing randomly because it returned the DAGs in random order and sometimes it failed because test_serialized_dag was removing only one file from the list of files but the file could be repeated in case a dag file had more than one DAG defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing randomly because it returned the DAGs in random order and
sometimes it failed because test_serialized_dag was removing only one file
from the list of files but the file could be repeated in
case a dag file had more than one DAG defined.
Issue link: AIRFLOW-6638
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.