Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs #7260

Merged
merged 1 commit into from
Jan 26, 2020

Conversation

JonnyDaenen
Copy link
Contributor

@JonnyDaenen JonnyDaenen commented Jan 25, 2020

Correction of small typo in error when getting GCP Dataflow jobs.


Issue link: Document only change, no JIRA issue

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Jan 25, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 25, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

@JonnyDaenen JonnyDaenen changed the title Fix typo in error for when getting dataflow jobs [AIRFLOW-XXXX] Fix typo in error for when getting dataflow jobs Jan 25, 2020
@JonnyDaenen JonnyDaenen changed the title [AIRFLOW-XXXX] Fix typo in error for when getting dataflow jobs [AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs Jan 25, 2020
@JonnyDaenen
Copy link
Contributor Author

JonnyDaenen commented Jan 25, 2020

Is there a way to easily change the commit message without creating a new fork/commit?
Also, how should I improve my commit message?

@mik-laj
Copy link
Member

mik-laj commented Jan 25, 2020

You can also create a second commit using Github' Web UI. Then the warning will disappear. You should add "[JIRA-NNNN]" prefix to commit message.

@codecov-io
Copy link

codecov-io commented Jan 25, 2020

Codecov Report

Merging #7260 into master will decrease coverage by 0.27%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7260      +/-   ##
==========================================
- Coverage   85.33%   85.05%   -0.28%     
==========================================
  Files         791      791              
  Lines       40137    40137              
==========================================
- Hits        34251    34140     -111     
- Misses       5886     5997     +111
Impacted Files Coverage Δ
airflow/gcp/hooks/dataflow.py 88.37% <0%> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 76.47% <0%> (-21.18%) ⬇️
airflow/jobs/backfill_job.py 91.88% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8325dd5...1fb23e3. Read the comment docs.

@potiuk potiuk merged commit 7e29430 into apache:master Jan 26, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 26, 2020

Awesome work, congrats on your first merged pull request!

@potiuk
Copy link
Member

potiuk commented Jan 26, 2020

Thanks @JonnyDaenen ! Just next time make sure the PR has [AIRFLOW-XXXX] prefix :)

@JonnyDaenen JonnyDaenen deleted the patch-1 branch January 27, 2020 10:09
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants