Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXXX] Update autolabeler config #7379

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 7, 2020


Issue link: Document only change, no JIRA issue

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@@ -20,46 +20,24 @@

labelPRBasedOnFilePath:
provider:GCP:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change GCP to Google?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe as separate change.

- airflow/**/gcs_*.py
- airflow/**/bigquery_*.py
- tests/gcp/**/*
- tests/gcp/*
- tests/providers/google/cloud/**/*
- tests/providers/google/cloud/*
- docs/howto/connection/gcp.rst
- docs/howto/connection/gcp_sql.rst
- docs/howto/operator/gcp/*

provider:AWS:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change AWS to Amazon?

- tests/**/aws_*.py
- tests/**/s3_*.py
- tests/**/ecs_*.py
- tests/**/emr_*.py
- docs/howto/connection/aws.rst
- docs/howto/operator/amazon/aws/*

provider:Azure:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change Azure to Microsoft?

- tests/**/azure_*.py
- airflow/providers/microsoft/azure/**/*
- tests/providers/microsoft/azure/**/*
- tests/providers/microsoft/azure/*

provider:Apache:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@potiuk potiuk merged commit e6d0b57 into apache:master Feb 7, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants