Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6758] Skip git version retrieval in case of invalid git #7382

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 7, 2020

This happens when you have shared clone of the repository


Issue link: AIRFLOW-6758

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

This happens when you have shared clone of the repository
@codecov-io
Copy link

codecov-io commented Feb 7, 2020

Codecov Report

Merging #7382 into master will decrease coverage by 54.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #7382       +/-   ##
==========================================
- Coverage   86.06%   31.7%   -54.37%     
==========================================
  Files         871     870        -1     
  Lines       40642   40629       -13     
==========================================
- Hits        34980   12882    -22098     
- Misses       5662   27747    +22085
Impacted Files Coverage Δ
...low/contrib/operators/wasb_delete_blob_operator.py 0% <0%> (-100%) ⬇️
...ing_platform/example_dags/example_display_video.py 0% <0%> (-100%) ⬇️
airflow/contrib/hooks/vertica_hook.py 0% <0%> (-100%) ⬇️
airflow/contrib/sensors/__init__.py 0% <0%> (-100%) ⬇️
airflow/hooks/mssql_hook.py 0% <0%> (-100%) ⬇️
airflow/hooks/webhdfs_hook.py 0% <0%> (-100%) ⬇️
airflow/contrib/sensors/emr_base_sensor.py 0% <0%> (-100%) ⬇️
...irflow/contrib/operators/slack_webhook_operator.py 0% <0%> (-100%) ⬇️
airflow/hooks/jdbc_hook.py 0% <0%> (-100%) ⬇️
airflow/operators/python_operator.py 0% <0%> (-100%) ⬇️
... and 738 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52db2ab...ec42fb7. Read the comment docs.

@mik-laj
Copy link
Member

mik-laj commented Feb 8, 2020

This is very problematic when worktree is used. 👍

@potiuk potiuk merged commit 951aa62 into apache:master Feb 9, 2020
potiuk added a commit that referenced this pull request Feb 10, 2020
This happens when you have shared clone of the repository

(cherry picked from commit 951aa62)
kaxil pushed a commit that referenced this pull request Feb 21, 2020
This happens when you have shared clone of the repository

(cherry picked from commit 951aa62)
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
…che#7382)

This happens when you have shared clone of the repository
kaxil pushed a commit that referenced this pull request Mar 19, 2020
This happens when you have shared clone of the repository

(cherry picked from commit 951aa62)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
…che#7382)

This happens when you have shared clone of the repository

(cherry picked from commit 951aa62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants