-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6764] Fixed environment installation for Linux #7390
[AIRFLOW-6764] Fixed environment installation for Linux #7390
Conversation
I switched to Linux environment for my home setup and find out some updates are needed in breezee's --initialize-virtualenv command. |
@@ -503,7 +503,7 @@ def do_setup(): | |||
# DEPENDENCIES_EPOCH_NUMBER in the Dockerfile | |||
##################################################################################################### | |||
setup_requires=[ | |||
'docutils>=0.14, <1.0', | |||
'docutils>=0.14, <0.16' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed in 0.16?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of our dependencies is incompatible with 0.16 and when you try it on a fresh system you get "incompatibility" problem (not sure which one) - until we fix it with pinnig - it's the simplest way to make it works out-of the box.
@@ -904,7 +904,7 @@ if [[ ${INITIALIZE_LOCAL_VIRTUALENV} == "true" ]]; then | |||
if [[ ${SYSTEM} == "Darwin" ]]; then | |||
echo " brew install sqlite mysql postgresql" | |||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many more Linuxes than Debian ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. but this is Darwin :) =-> MacOS
@@ -904,7 +904,7 @@ if [[ ${INITIALIZE_LOCAL_VIRTUALENV} == "true" ]]; then | |||
if [[ ${SYSTEM} == "Darwin" ]]; then | |||
echo " brew install sqlite mysql postgresql" | |||
else | |||
echo " sudo apt-get install openssl sqlite libmysqlclient-dev libmysqld-dev postgresql --confirm" | |||
echo " sudo apt-get install python3-dev python-dev openssl sqlite default-libmysqlclient-dev libmysqld-dev postgresql --confirm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why python-dev and python3-dev?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case. I want to backport it to 1.10 so I want it to work there as well. There are still some distros that have python2 as default and it will be like that for a while so it's better to leave it like that just in case.
(cherry picked from commit 53ba6d6)
(cherry picked from commit 53ba6d6)
(cherry picked from commit 53ba6d6)
(cherry picked from commit 53ba6d6)
Issue link: AIRFLOW-6764
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.