Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6821] - Success callback not called when task marked as succ… #7447

Merged
merged 1 commit into from Feb 20, 2020

Conversation

saurabhdhupar
Copy link
Contributor

@saurabhdhupar saurabhdhupar commented Feb 17, 2020

…ess from UI


Issue link: AIRFLOW-6821

Make sure to mark the boxes below before creating PR: [x]

  • [ x] Description above provides context of the change
  • [ x] Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • [x ] Unit tests coverage for changes (not needed for documentation changes)
  • [x ] Commits follow "How to write a good git commit message"
  • [ x] Relevant documentation is updated including usage instructions.
  • [x ] I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:Scheduler Scheduler or dag parsing Issues label Feb 17, 2020
@codecov-io
Copy link

Codecov Report

Merging #7447 into master will increase coverage by 53.41%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7447       +/-   ##
===========================================
+ Coverage   32.95%   86.36%   +53.41%     
===========================================
  Files         878      878               
  Lines       41219    41222        +3     
===========================================
+ Hits        13584    35603    +22019     
+ Misses      27635     5619    -22016
Impacted Files Coverage Δ
airflow/jobs/local_task_job.py 90.12% <100%> (+67.04%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0%> (-39.44%) ⬇️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 69.38% <0%> (-25.52%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
airflow/bin/airflow 84.61% <0%> (ø) ⬆️
airflow/plugins_manager.py 86.95% <0%> (+0.72%) ⬆️
airflow/bin/cli.py 94.73% <0%> (+2.1%) ⬆️
airflow/executors/celery_executor.py 88.51% <0%> (+3.37%) ⬆️
... and 749 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83ce26...f0dca49. Read the comment docs.

@kaxil kaxil merged commit 6cd37da into apache:master Feb 20, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 20, 2020

Awesome work, congrats on your first merged pull request!

galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil pushed a commit that referenced this pull request Mar 17, 2020
kaxil pushed a commit that referenced this pull request Mar 19, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler Scheduler or dag parsing Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants