Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6837] limit description len of dag in home #7457

Merged
merged 1 commit into from Feb 22, 2020
Merged

[AIRFLOW-6837] limit description len of dag in home #7457

merged 1 commit into from Feb 22, 2020

Conversation

pingzh
Copy link
Contributor

@pingzh pingzh commented Feb 18, 2020

as it makes dags link not clickable

The dag with long description:
image

Before:
image

After:

image


Issue link: AIRFLOW-6837

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Feb 18, 2020
@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #7457 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7457      +/-   ##
==========================================
+ Coverage   86.74%   86.78%   +0.04%     
==========================================
  Files         883      886       +3     
  Lines       41635    41975     +340     
==========================================
+ Hits        36116    36428     +312     
- Misses       5519     5547      +28
Impacted Files Coverage Δ
airflow/utils/dag_processing.py 87.93% <0%> (-0.2%) ⬇️
airflow/providers/google/cloud/hooks/datafusion.py 81.3% <0%> (ø)
...rs/google/cloud/example_dags/example_datafusion.py 93.1% <0%> (ø)
...low/providers/google/cloud/operators/datafusion.py 97.54% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848fbab...ef177c8. Read the comment docs.

@kaxil
Copy link
Member

kaxil commented Feb 21, 2020

Can you rebase to latest master and resolve the conflicts

as it makes dags link not clickable
@pingzh
Copy link
Contributor Author

pingzh commented Feb 21, 2020

Can you rebase to latest master and resolve the conflicts

Rebased. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants