Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6789] BugFix: Fix Default Worker concurrency #7494

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Feb 21, 2020

9b5dbf9#diff-bbf16e7665ac448883f2ceeb40db35cdR444 commit in airflow 1.10.8 (1.10.9) introduced a bug. It changed default worker concurrency


Issue link: AIRFLOW-6789

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil
Copy link
Member Author

kaxil commented Feb 21, 2020

This only exists in 1.10.8/1.10.9 (v1-10-* branches). Master does not have this bug

@kaxil kaxil requested a review from ashb February 21, 2020 23:45
@codecov-io
Copy link

Codecov Report

Merging #7494 into v1-10-test will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           v1-10-test    #7494      +/-   ##
==============================================
+ Coverage       80.96%   81.34%   +0.37%     
==============================================
  Files             529      529              
  Lines           36437    36437              
==============================================
+ Hits            29502    29640     +138     
+ Misses           6935     6797     -138
Impacted Files Coverage Δ
airflow/utils/dag_processing.py 91.84% <0%> (-0.17%) ⬇️
airflow/bin/cli.py 66.91% <0%> (-0.11%) ⬇️
...etes_request_factory/kubernetes_request_factory.py 100% <0%> (+0.86%) ⬆️
airflow/contrib/kubernetes/pod.py 100% <0%> (+4.16%) ⬆️
airflow/contrib/kubernetes/refresh_config.py 74.5% <0%> (+23.52%) ⬆️
...rflow/contrib/operators/kubernetes_pod_operator.py 96.84% <0%> (+40%) ⬆️
airflow/contrib/kubernetes/pod_generator.py 87.5% <0%> (+45%) ⬆️
airflow/contrib/kubernetes/pod_launcher.py 92.48% <0%> (+47.36%) ⬆️
airflow/contrib/kubernetes/volume.py 100% <0%> (+50%) ⬆️
airflow/contrib/kubernetes/volume_mount.py 100% <0%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2aa85...e4f68fb. Read the comment docs.

@kaxil kaxil merged commit 4a5b47b into apache:v1-10-test Feb 22, 2020
@kaxil kaxil deleted the bf-fix branch February 22, 2020 11:03
kaxil added a commit to astronomer/airflow that referenced this pull request Feb 28, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants