Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6959] Use NULL as dag.description default value #7593

Merged

Conversation

zhongjiajie
Copy link
Member

@zhongjiajie zhongjiajie commented Feb 29, 2020

…elated UI


Issue link: AIRFLOW-6959

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@zhongjiajie
Copy link
Member Author

zhongjiajie commented Feb 29, 2020

The detail change as below

UPDATE AT 2020-03-02: section homepage without description and dag detail page without description are same as before.

section old new
database empty string null value
homepage without description
dag detail page with description
dag detail page without description

@codecov-io
Copy link

codecov-io commented Feb 29, 2020

Codecov Report

Merging #7593 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7593   +/-   ##
=======================================
  Coverage   86.93%   86.93%           
=======================================
  Files         915      915           
  Lines       44158    44158           
=======================================
  Hits        38387    38387           
  Misses       5771     5771           
Impacted Files Coverage Δ
airflow/models/dag.py 91.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271ee64...17b608f. Read the comment docs.

@zhongjiajie
Copy link
Member Author

PTAL @kaxil @potiuk @mik-laj

@zhongjiajie zhongjiajie force-pushed the dag_description_should_be_null_for_redener branch 2 times, most recently from 010356a to 7b624f7 Compare March 3, 2020 08:08
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Mar 3, 2020
@zhongjiajie zhongjiajie force-pushed the dag_description_should_be_null_for_redener branch from 7b624f7 to ad69802 Compare March 3, 2020 08:10
@zhongjiajie zhongjiajie changed the title [AIRFLOW-6959] Use NULL as dag.description default value and change r… [AIRFLOW-6959] Use NULL as dag.description default value Mar 3, 2020
@zhongjiajie zhongjiajie force-pushed the dag_description_should_be_null_for_redener branch 7 times, most recently from 1a00c7e to 39bebbd Compare March 9, 2020 01:55
@zhongjiajie zhongjiajie requested a review from mik-laj March 9, 2020 02:47
@zhongjiajie zhongjiajie force-pushed the dag_description_should_be_null_for_redener branch from 39bebbd to 17b608f Compare March 15, 2020 09:11
@zhongjiajie
Copy link
Member Author

Fix conflict on UPDATING.md

@zhongjiajie
Copy link
Member Author

@feluelle feluelle merged commit ff3700d into apache:master Mar 20, 2020
@zhongjiajie zhongjiajie deleted the dag_description_should_be_null_for_redener branch March 20, 2020 09:59
@zhongjiajie
Copy link
Member Author

Thanks everyone

@kaxil kaxil added this to the Airflow 1.10.11 milestone Apr 27, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Jun 5, 2020
kaxil pushed a commit that referenced this pull request Jun 5, 2020
@kaxil
Copy link
Member

kaxil commented Jun 5, 2020

Cherry-picked to v1-10-test: d0de41c

kaxil pushed a commit that referenced this pull request Jul 1, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants