[AIRFLOW-6574] Adding private_environment to docker operator. #7671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker operator currently does not have a means to pass in an environment dict that is not exposed to the frontend. - Updating docs and ensuring code is flake8. - Adding a test and updating documentation.
feluelle
reviewed
Mar 10, 2020
feluelle
reviewed
Mar 10, 2020
|
Updated, and ready for review again. |
CaptainCuddleCube
force-pushed
the
6574-private-environment-to-docker-operator
branch
from
b941fe2
to
7c81db7
Compare
|
@feluelle |
feluelle
approved these changes
Mar 23, 2020
potiuk
approved these changes
Mar 30, 2020
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker operator currently does not have a means to pass in an environment dict that is not exposed to the frontend.
This links to issue 6574.
Issue link: AIRFLOW-6574
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.