Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5705] Fix bug in Secrets Backend #7742

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Mar 16, 2020

Follow up of #6376 . There were some bugs where the renaming of configs was not applied at all places


Issue link: AIRFLOW-5705

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

cc @dstandish

@kaxil kaxil requested a review from potiuk March 16, 2020 23:35
@kaxil
Copy link
Member Author

kaxil commented Mar 16, 2020

I will add more tests as earlier tests didn't cover this Added

@kaxil kaxil changed the title [AIRFLOW-5705] Fix bug in Secrets Backend [AIRFLOW-5705] Fix bug in Secrets Backend & add test Mar 17, 2020
@kaxil kaxil changed the title [AIRFLOW-5705] Fix bug in Secrets Backend & add test [AIRFLOW-5705] Fix bug in Secrets Backend Mar 17, 2020
@codecov-io
Copy link

codecov-io commented Mar 17, 2020

Codecov Report

Merging #7742 into master will decrease coverage by 0.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7742      +/-   ##
==========================================
- Coverage   86.94%   86.18%   -0.77%     
==========================================
  Files         915      915              
  Lines       44176    44176              
==========================================
- Hits        38407    38071     -336     
- Misses       5769     6105     +336     
Impacted Files Coverage Δ
airflow/secrets/__init__.py 100.00% <100.00%> (+10.25%) ⬆️
...flow/providers/apache/cassandra/hooks/cassandra.py 21.51% <0.00%> (-72.16%) ⬇️
...w/providers/apache/hive/operators/mysql_to_hive.py 35.84% <0.00%> (-64.16%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0.00%> (-55.56%) ⬇️
airflow/providers/postgres/operators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
airflow/providers/redis/operators/redis_publish.py 50.00% <0.00%> (-50.00%) ⬇️
airflow/kubernetes/volume.py 52.94% <0.00%> (-47.06%) ⬇️
airflow/providers/mongo/sensors/mongo.py 53.33% <0.00%> (-46.67%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0.00%> (-45.08%) ⬇️
airflow/providers/mysql/operators/mysql.py 55.00% <0.00%> (-45.00%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b5fc7...dc1c48e. Read the comment docs.

@kaxil kaxil merged commit 4ff9d63 into apache:master Mar 17, 2020
@kaxil kaxil deleted the secret-backend-bug branch March 17, 2020 01:19
@dstandish
Copy link
Contributor

Sorry @kaxil / thanks

kaxil added a commit that referenced this pull request Mar 22, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Apr 28, 2020
(cherry picked from commit 4ff9d63)
(cherry picked from commit f8e7276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants