Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-7079] Remove redundant code for storing template_fields #7750

Merged
merged 2 commits into from Mar 17, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Mar 17, 2020

We don't need the logic in #6715 to store fields used in Extra Operator links as now we store all the template_fields (#7633)


Issue link: AIRFLOW-7079

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested review from ashb and potiuk March 17, 2020 15:53
@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Mar 17, 2020
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that template_fields are now serialized by default ... Then this is perfectly OK

@potiuk
Copy link
Member

potiuk commented Mar 17, 2020

However serialization tests are failing now :)

@codecov-io
Copy link

Codecov Report

Merging #7750 into master will decrease coverage by 22.33%.
The diff coverage is 98.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7750       +/-   ##
===========================================
- Coverage   86.96%   64.63%   -22.34%     
===========================================
  Files         915      914        -1     
  Lines       44188    44185        -3     
===========================================
- Hits        38429    28559     -9870     
- Misses       5759    15626     +9867
Impacted Files Coverage Δ
...viders/google/cloud/operators/kubernetes_engine.py 97.18% <100%> (-0.08%) ⬇️
...oviders/google/cloud/utils/credentials_provider.py 91.83% <100%> (-1.39%) ⬇️
airflow/providers/qubole/operators/qubole.py 87.69% <100%> (-0.88%) ⬇️
airflow/utils/process_utils.py 27.55% <100%> (-45.71%) ⬇️
...rflow/providers/google/cloud/operators/bigquery.py 91.37% <100%> (-0.12%) ⬇️
airflow/providers/google/cloud/hooks/base.py 96.27% <97.29%> (+0.37%) ⬆️
...low/contrib/operators/wasb_delete_blob_operator.py 0% <0%> (-100%) ⬇️
airflow/contrib/hooks/vertica_hook.py 0% <0%> (-100%) ⬇️
airflow/contrib/sensors/__init__.py 0% <0%> (-100%) ⬇️
airflow/hooks/mssql_hook.py 0% <0%> (-100%) ⬇️
... and 500 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a54512...2bfb401. Read the comment docs.

@kaxil kaxil merged commit de7e934 into apache:master Mar 17, 2020
@kaxil kaxil deleted the remove-redundant-code branch March 17, 2020 19:03
kaxil added a commit that referenced this pull request Mar 24, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
kaxil added a commit that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:serialization provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants