[AIRFLOW-4679] Make airflow/operators Pylint compatible #7757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove unused lineage_data field in BashOperator - fix string formatting in AirflowException in PythonVirtualenvOperator
turbaszek
reviewed
Mar 18, 2020
| raise AirflowException('{} only supports functions for python_callable arg', | ||
| self.__class__.__name__) | ||
| raise AirflowException('{} only supports functions for python_callable arg'.format( | ||
| self.__class__.__name__)) |
| @@ -100,8 +100,6 @@ def execute(self, context): | |||
| for k, v in airflow_context_vars.items()])) | |||
| env.update(airflow_context_vars) | |||
|
|
|||
| self.lineage_data = self.bash_command | |||
There was a problem hiding this comment.
Isn't it something related to lineage? 👀
There was a problem hiding this comment.
No, it is no longer required. The lineage backend has been modified and this was used earlier
Codecov Report
@@ Coverage Diff @@
## master #7757 +/- ##
==========================================
- Coverage 86.98% 86.91% -0.08%
==========================================
Files 915 915
Lines 44231 44224 -7
==========================================
- Hits 38476 38436 -40
- Misses 5755 5788 +33
Continue to review full report at Codecov.
|
kaxil
approved these changes
Mar 19, 2020
feluelle
deleted the
feature/AIRFLOW-4679-airflow-operators-pylint-compatible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: AIRFLOW-4679
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.