Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Airflow Variables from AWS Systems Manager Parameter Store #7945

Merged
merged 1 commit into from Mar 28, 2020
Merged

Get Airflow Variables from AWS Systems Manager Parameter Store #7945

merged 1 commit into from Mar 28, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Mar 28, 2020 •
edited

Get Airflow Variables from AWS Systems Manager Parameter Store

Please only check the last commit

Make sure to mark the boxes below before creating PR: [x]

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested review from ashb and potiuk March 28, 2020 03:25
@boring-cyborg boring-cyborg bot added area:docs area:secrets provider:amazon-aws AWS/Amazon - related issues provider:google Google (including GCP) related issues labels Mar 28, 2020
@kaxil kaxil force-pushed the add-variables-aws-param-store branch from 6bde49e to 59d96da Compare March 28, 2020 03:52
@kaxil kaxil mentioned this pull request Mar 28, 2020
Merged
5 tasks
@kaxil kaxil force-pushed the add-variables-aws-param-store branch from 59d96da to 506c3ad Compare March 28, 2020 11:36
@kaxil kaxil changed the title [Depends on #7923 & #7944]Get Airflow Variables from AWS Systems Manager Parameter Store [Depends on #7948]Get Airflow Variables from AWS Systems Manager Parameter Store Mar 28, 2020
@kaxil kaxil changed the title [Depends on #7948]Get Airflow Variables from AWS Systems Manager Parameter Store Get Airflow Variables from AWS Systems Manager Parameter Store Mar 28, 2020
@kaxil kaxil force-pushed the add-variables-aws-param-store branch from 506c3ad to f3738c7 Compare March 28, 2020 12:03
@codecov-io
Copy link

codecov-io commented Mar 28, 2020 •
edited

Codecov Report

Merging #7945 into master will increase coverage by 0.04%.
The diff coverage is 98.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7945      +/-   ##
==========================================
+ Coverage   86.36%   86.40%   +0.04%     
==========================================
  Files         929      931       +2     
  Lines       45036    45170     +134     
==========================================
+ Hits        38895    39029     +134     
  Misses       6141     6141
Impacted Files Coverage Δ
airflow/executors/kubernetes_executor.py 56.87% <0.00%> (ø)
airflow/models/dag.py 91.08% <ø> (+0.08%) ⬆️
airflow/utils/log/logging_mixin.py 95.38% <ø> (ø)
airflow/secrets/base_secrets.py 89.47% <80.00%> (-4.65%) ⬇️
airflow/exceptions.py 100.00% <100.00%> (ø)
airflow/hooks/dbapi_hook.py 91.73% <100.00%> (ø)
airflow/hooks/filesystem.py 90.90% <100.00%> (ø)
airflow/jobs/scheduler_job.py 90.94% <100.00%> (ø)
airflow/models/dagbag.py 89.83% <100.00%> (+0.08%) ⬆️
airflow/models/serialized_dag.py 94.18% <100.00%> (+1.78%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4af4f...f3738c7. Read the comment docs.

@kaxil kaxil merged commit 7239d9a into apache:master Mar 28, 2020
@kaxil kaxil deleted the add-variables-aws-param-store branch March 28, 2020 13:35
@kaxil
Copy link
Member Author

kaxil commented Mar 28, 2020

Ci failure is unrelated

@kaxil kaxil added this to the Airflow 1.10.10 milestone Mar 28, 2020
kaxil added a commit that referenced this pull request Mar 28, 2020
@kaxil
Get Airflow Variables from AWS Systems Manager Parameter Store (#7945)
4b0920c 
(cherry picked from commit 7239d9a)
kaxil added a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
@kaxil
Get Airflow Variables from AWS Systems Manager Parameter Store (apach…
765bdb2 
…e#7945)

(cherry picked from commit 7239d9a)
kaxil added a commit that referenced this pull request Mar 30, 2020
@kaxil
Get Airflow Variables from AWS Systems Manager Parameter Store (#7945)
f1108c1 
(cherry picked from commit 7239d9a)
kaxil added a commit that referenced this pull request Apr 1, 2020
@kaxil
Get Airflow Variables from AWS Systems Manager Parameter Store (#7945)
b0bc9cb 
(cherry picked from commit 7239d9a)
@kaxil kaxil added the kind:feature Feature Requests label Apr 1, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Apr 28, 2020
@kaxil
Get Airflow Variables from AWS Systems Manager Parameter Store (apach…
6a7130f 
…e#7945)

(cherry picked from commit 7239d9a)
(cherry picked from commit b0bc9cb)
@kaxil kaxil mentioned this pull request Apr 29, 2020
Merged
kaxil added a commit to astronomer/airflow that referenced this pull request May 4, 2020
@kaxil
Get Airflow Variables from AWS Systems Manager Parameter Store (apach…
5a0ee10 
…e#7945)

(cherry picked from commit 7239d9a)
(cherry picked from commit b0bc9cb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@ashb ashb Awaiting requested review from ashb

Assignees
No one assigned
Labels
area:secrets kind:feature Feature Requests provider:amazon-aws AWS/Amazon - related issues provider:google Google (including GCP) related issues
Projects
None yet
Milestone
Airflow 1.10.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kaxil @codecov-io @potiuk