Rename CloudBaseHook to GoogleBaseHook and move it to google.common #8011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
k8s
provider:google
turbaszek
force-pushed
the
move-google-cloud-base-hook-to-common
branch
2 times, most recently
from
d47bfa2
to
37de5dc
Compare
turbaszek
force-pushed
the
move-google-cloud-base-hook-to-common
branch
from
37de5dc
to
b907311
Compare
mik-laj
reviewed
Mar 30, 2020
| @@ -23,10 +23,10 @@ | |||
|
|
|||
| from googleapiclient.discovery import Resource, build | |||
|
|
|||
| from airflow.providers.google.cloud.hooks.base import CloudBaseHook | |||
| from airflow.providers.google.common.hooks.base import GoogleBaseHook | |||
There was a problem hiding this comment.
Should we move this hook to common package?
There was a problem hiding this comment.
I think so, good catch! @potiuk WDYT?
mik-laj
approved these changes
Mar 30, 2020
potiuk
approved these changes
Mar 30, 2020
|
Hi. Travis is sad. This is a blocker for me because I would like to take care of the latest improvements. in the package/class name. |
mik-laj
reviewed
Mar 30, 2020
| @@ -29,10 +29,10 @@ | |||
| ImageObjectDetectionModelDeploymentMetadata, InputConfig, Model, Operation, PredictResponse, TableSpec, | |||
| ) | |||
|
|
|||
| from airflow.providers.google.cloud.hooks.base import CloudBaseHook | |||
| from airflow.providers.google.common.hooks.base import GoogleBaseHook | |||
There was a problem hiding this comment.
Suggested change
| from airflow.providers.google.common.hooks.base import GoogleBaseHook | |
| from airflow.providers.google.common.hooks.base_google import GoogleBaseHook |
We agreed to such a convention in the case of AWS. In the case of Google, we should also use it. I will add a commit to this branch, which corrects it. In next step, I will start new PR starting from this branch, which will correct other errors.
mik-laj
force-pushed
the
move-google-cloud-base-hook-to-common
branch
from
568d914
to
a4f6286
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: WILL BE INSERTED BY boring-cyborg
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.