Prevent sequential scan of task instance table when clearing dags #8014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exact dag_id is known so no need to perform a like here which caused a sequential scan.
|
Restarted the failing test |
Codecov Report
@@ Coverage Diff @@
## master #8014 +/- ##
===========================================
- Coverage 87.19% 59.86% -27.33%
===========================================
Files 933 932 -1
Lines 45289 45331 +42
===========================================
- Hits 39490 27139 -12351
- Misses 5799 18192 +12393
Continue to review full report at Codecov.
|
kaxil
pushed a commit
that referenced
this pull request
Mar 31, 2020
The exact dag_id is known so no need to perform a like here which caused a sequential scan. (cherry picked from commit cfc0d6c)
kaxil
pushed a commit
that referenced
this pull request
Apr 1, 2020
The exact dag_id is known so no need to perform a like here which caused a sequential scan. (cherry picked from commit cfc0d6c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that when performing an
airflow clearwithout specifying--exclude_subdagsa sequential scan is made of the task instance table which in our case is quite large and thus time consuming!The actual subdag id's are already to hand so there's actually no need to use a
likehere.This code is already covered by the following unit test:
def test_subdag_clear_parentdag_downstream_clear(self):
airflow/tests/jobs/test_backfill_job.py
Line 1184 in 33a2372
Issue link: WILL BE INSERTED BY boring-cyborg
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.