Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests for Storing Dag Code in DB #8152

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Apr 5, 2020

The original test does not cover the real case where DAG model actually calls dag.sync_to_db(). This is where the subdag fileloc is set to parent dag's fileloc, so it is important to change this behavior

Based on #8151


Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

Original test does not cover the real case where DAG model actually calls `dag.sync_to_db()`. This is where the subdag fileloc is set to parent dag's fileloc, so it is important to change this behavior
@kaxil kaxil requested a review from ashb April 5, 2020 02:04
@codecov-io
Copy link

codecov-io commented Apr 5, 2020

Codecov Report

Merging #8152 into master will increase coverage by 21.64%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #8152       +/-   ##
===========================================
+ Coverage   66.39%   88.03%   +21.64%     
===========================================
  Files         935      935               
  Lines       45170    45170               
===========================================
+ Hits        29990    39766     +9776     
+ Misses      15180     5404     -9776     
Impacted Files Coverage Δ
airflow/kubernetes/volume_mount.py 44.44% <0.00%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0.00%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0.00%> (-39.44%) ⬇️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 69.69% <0.00%> (-25.26%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0.00%> (-23.53%) ⬇️
airflow/providers/google/cloud/operators/vision.py 99.63% <0.00%> (+0.36%) ⬆️
...osoft/azure/operators/azure_container_instances.py 78.28% <0.00%> (+0.65%) ⬆️
airflow/cli/cli_parser.py 97.24% <0.00%> (+0.91%) ⬆️
airflow/providers/postgres/hooks/postgres.py 94.36% <0.00%> (+1.40%) ⬆️
...rflow/providers/databricks/operators/databricks.py 92.24% <0.00%> (+1.72%) ⬆️
... and 498 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d1714...2d3bf60. Read the comment docs.

@kaxil kaxil merged commit 9fda018 into apache:master Apr 5, 2020
@kaxil kaxil deleted the improve-tests branch April 5, 2020 13:01
@kaxil
Copy link
Member Author

kaxil commented Apr 5, 2020

The PR targetting v1-10-test has been approved and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants