Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-7111] Add generate_presigned_url method to S3Hook #8441

Merged
merged 3 commits into from Apr 24, 2020

Conversation

jcarless
Copy link
Contributor

@jcarless jcarless commented Apr 18, 2020

Boto3 generate_presigned_url exposed to S3Hook.

Jira: https://issues.apache.org/jira/browse/AIRFLOW-7111


  • [ x ] Description above provides context of the change
  • [ x ] Unit tests coverage for changes (not needed for documentation changes)
  • [ x ] Commits follow "How to write a good git commit message"
  • [ x ] Relevant documentation is updated including usage instructions.
  • [ x ] I will engage committers as explained in Contribution Workflow Example.

@boring-cyborg boring-cyborg bot added the provider:amazon-aws AWS/Amazon - related issues label Apr 18, 2020
@potiuk
Copy link
Member

potiuk commented Apr 19, 2020

Looks good but the static checks are failing at flake8. I recommend installing pre-commit @jcarless !

Copy link
Contributor

@RosterIn RosterIn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to fix the static check

airflow/providers/amazon/aws/hooks/s3.py:741:111: E501 line too long (133 > 110 characters)
airflow/providers/amazon/aws/hooks/s3.py:743:111: E501 line too long (147 > 110 characters)

@jcarless jcarless force-pushed the AIRFLOW-7111 branch 3 times, most recently from 34ea0c6 to f4266d4 Compare April 20, 2020 21:51
@jcarless
Copy link
Contributor Author

@potiuk @RosterIn Fixed those flake8 errors and rebased to the latest master. I'm not sure why Dockerfile linting is failing though.

Co-Authored-By: Kaxil Naik <kaxilnaik@gmail.com>
@kaxil kaxil merged commit b6434de into apache:master Apr 24, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 24, 2020

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants