Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Upload Multiple Entity Read Files to specified big query dataset #8610

Merged

Conversation

michalslowikowski00
Copy link
Contributor

Added example DAG and hook method for Uploading Multiple Entity Read Files to specified big query dataset


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@michalslowikowski00 michalslowikowski00 force-pushed the upload-multiple-entity-read-files branch from 9514594 to bcffa51 Compare May 4, 2020 14:24
@mik-laj mik-laj added the provider:google Google (including GCP) related issues label May 5, 2020
@turbaszek
Copy link
Member

@michalslowikowski00 can you rebase please?

@michalslowikowski00 michalslowikowski00 force-pushed the upload-multiple-entity-read-files branch from bcffa51 to 41048ee Compare May 9, 2020 06:05
@michalslowikowski00
Copy link
Contributor Author

@turbaszek Rebased. I fixed also variables names and cleaned code a little bit.

@turbaszek
Copy link
Member

@michalslowikowski00 mypy is not happy:

airflow/providers/google/marketing_platform/example_dags/example_display_video.py:70: error: Need type annotation for 'CREATE_SDF_DOWNLOAD_TASK_BODY_REQUEST'

@michalslowikowski00
Copy link
Contributor Author

Yes, I will fix it today, later.

@michalslowikowski00
Copy link
Contributor Author

@turbaszek I am stupid, I run pre-commit but forgot to push fixes.

@michalslowikowski00 michalslowikowski00 force-pushed the upload-multiple-entity-read-files branch from 41048ee to 69a4298 Compare May 10, 2020 10:11
@turbaszek turbaszek merged commit 79ef8be into apache:master May 10, 2020
@turbaszek turbaszek deleted the upload-multiple-entity-read-files branch May 10, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants