Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template_fields to GCSFileTransformOperator #8870

Closed
wants to merge 1 commit into from
Closed

Add template_fields to GCSFileTransformOperator #8870

wants to merge 1 commit into from

Conversation

dinigo
Copy link
Contributor

@dinigo dinigo commented May 14, 2020

source_object and destination_object were not being templated, thus not rendered correctly.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • [] Unit tests coverage for changes (not needed for documentation changes)
  • [] Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • [] Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

source_object and destination_object were not being templated, thus not rendered correctly.
@mik-laj
Copy link
Member

mik-laj commented May 17, 2020

@dinigo Static checks are sad. Can you fix it?

@stale
Copy link

stale bot commented Jul 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jul 2, 2020
@stale stale bot closed this Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants