-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-8875] fix Dag Run UI execution date with timezone cannot be saved issue #8875
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
@ashb the quarantined CI build job fails.. any idea? |
Looking better @realradical! Can you test that changing the timezone in the UI updates this field while the page is open? (If it doesn't it means it's missing an html class) I also think that we should test more than one timezone, and for completeness, test what happens when the form is submitted without a TZ (it should use the "default" configured TZ. So we should also use |
@ashb I tried changing the timezone in the UI and it works! I used Personally I don't think we need to cover this case, the frontend should make sure that the datetime submitted always with a timezone. |
@realradical I think the backend change you have here is good! With it it should accept any datetime that the UI displays, but without it it would only accept TZ in the current TZ. i.e. the change as you had it meant you could copy-and-paste a date-time with TZ and have it work, so I'd still think this is a good change to have. |
@ashb i accidentally closed the pr. will create another one now. sorry about it |
This PR is to address the following bug: #8842
Airflow 1.10.10 displays datetime with timezone on the web UI. Currently, when user tries to create a dag run on the UI, it gives invalid DateTime error which prevents the dag run being created.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.