Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JAVA_HOME env var back to CI Docker image #8929

Closed
wants to merge 1 commit into from

Conversation

ashb
Copy link
Member

@ashb ashb commented May 20, 2020

I mistakenly removed this in #8919, but it is needed for Hadoop to
function


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

I mistakenly removed this in apache#8919, but it is needed for Hadoop to
function
@ashb
Copy link
Member Author

ashb commented May 20, 2020

Damn

@dimberman
Copy link
Contributor

@ashb yup, was gonna mention it tonight (didn't want to bother you if you were off for the day)

@ashb
Copy link
Member Author

ashb commented May 20, 2020

Not sure I can fix it, maybe we change default-jre-headless to default-jdk-headless in Dockerfile.ci

Could you try that @dimberman ?

@ashb
Copy link
Member Author

ashb commented May 20, 2020

This is failing now because Hive isn't creating (or has corrupt) meta store. But that doesn't seem to be related to JDK vs JRE. Confused

@ashb
Copy link
Member Author

ashb commented May 20, 2020

Think I've got a fix -- using https://adoptopenjdk.net/index.html instead.

@ashb
Copy link
Member Author

ashb commented May 20, 2020

Closing in favour of #8938

@ashb ashb closed this May 20, 2020
@ashb ashb deleted the hadoop-needs-JAVA_HOME branch May 20, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants