Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting code block in TESTING.rst #8985

Merged
merged 4 commits into from
May 23, 2020
Merged

Fix formatting code block in TESTING.rst #8985

merged 4 commits into from
May 23, 2020

Conversation

ad-m
Copy link
Contributor

@ad-m ad-m commented May 23, 2020


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • [_] Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@ad-m
Copy link
Contributor Author

ad-m commented May 23, 2020

@potiuk , could you review that and provide any comments? I have been informed that you have the widest knowledge of testing in the entire Apache Airflow project.

@potiuk
Copy link
Member

potiuk commented May 23, 2020

Stylelint complains - it's good but the style problems need to be fixed.

TESTING.rst Outdated Show resolved Hide resolved
TESTING.rst Outdated Show resolved Hide resolved
ad-m and others added 2 commits May 23, 2020 11:08
Co-authored-by: Kamil Breguła <mik-laj@users.noreply.github.com>
Co-authored-by: Kamil Breguła <mik-laj@users.noreply.github.com>
@ad-m ad-m requested a review from mik-laj May 23, 2020 09:08
@mik-laj
Copy link
Member

mik-laj commented May 23, 2020

Screenshot 2020-05-23 at 11 10 04
It does not look good.

@ad-m
Copy link
Contributor Author

ad-m commented May 23, 2020

Screenshot 2020-05-23 at 11 10 04
It does not look good.

You looking on section which I don't modify. It was out of scope of that PR. I decided to extend scope of that PR to include that section.

@mik-laj mik-laj merged commit f3456b1 into apache:master May 23, 2020
@ad-m ad-m deleted the patch-1 branch May 23, 2020 11:14
@ad-m
Copy link
Contributor Author

ad-m commented May 23, 2020

@potiuk , @mik-laj , thanks for you help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants