-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Breeze Documentation to have WSL 2 Instructions instead of WSL 1 #9057
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
Nice! Thanks! Few nits and style pre-commit check which is I think about extra spaces. FYI if you install pre-commit (see https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#pre-commit-hooks) the style will be fixed automatically during pre-commit :) |
Thanks for your time, I'll take a look over all of these and fix them. |
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
Still some spaces at the end of lines :(. |
Still working on it, got a spell check extension and fixed a spelling issue, just figured out how to set-up pre-commit and now latest commit passes pre-commit tests. Moving on to linting next to see if there's some formatting I'm missing. Thanks for you patience, open source contribution and tooling is new to me. |
Perfect! Thank you for your patience as well :). We do have quite a set of tools that make our work really consistent even for newcomers and make committer lives a bit easier as we automate all checks we can :). |
Awesome work, congrats on your first merged pull request! |
WSL 2 is now available on stable version of Windows 10: https://docs.microsoft.com/en-us/windows/wsl/wsl2-index
WSL 2 works with Docker Desktop on Windows with better performance: https://docs.docker.com/docker-for-windows/wsl/
After installing WSL 2 and Docker Desktop then Breeze works with no further configuration.
WSL 1 and WSL 2 are very different technology stacks with pros and cons to both. However I have not heard of any success stories of trying to use Breeze on WSL 1, I am therefore proposing we replace the WSL 1 section with a WSL 2 section seems to work almost instantly. If someone wants to have a WSL 1 section we could 2 separate instructions .
Finally I used WSL 2 and breeze to create this pull request and have added a few extra tips based on my experience.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.