Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-9347] Fix QuboleHook unable to add list to tags #9349

Merged
merged 3 commits into from
Jun 24, 2020

Conversation

egibbm
Copy link
Contributor

@egibbm egibbm commented Jun 17, 2020

Upon upgrading to 1.10.10, existing behavior of accepting a list of tags in QuboleOperator() dag have broken due to a refactor. This fix should have the same behavior of handling tags as expected before the refactor.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 17, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

@egibbm egibbm changed the title [#9347] Fix QuboleHook unable to add list to tags [AIRFLOW-9347] Fix QuboleHook unable to add list to tags Jun 17, 2020
@egibbm egibbm force-pushed the 9347-qubolehooks-tags-list branch from 07bca5a to d2782db Compare June 17, 2020 14:52
@egibbm egibbm force-pushed the 9347-qubolehooks-tags-list branch from d2782db to d48ea0a Compare June 17, 2020 15:12
@chattarajoy
Copy link
Contributor

thanks for taking this up @egibbm . LGTM

@msumit msumit merged commit 3190db5 into apache:master Jun 24, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 24, 2020

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants