Add airflow upgrade-check command (MVP) (v1-10-test) #9467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mik-laj
changed the title
dimberman
force-pushed
the
v1-10-test
branch
13 times, most recently
from
238d841
to
2f17299
Compare
dimberman
force-pushed
the
v1-10-test
branch
5 times, most recently
from
4f848da
to
e0bdf95
Compare
potiuk
force-pushed
the
v1-10-test
branch
4 times, most recently
from
845bcbe
to
90446e5
Compare
kaxil
force-pushed
the
v1-10-test
branch
4 times, most recently
from
c644d53
to
5a54173
Compare
turbaszek
reviewed
Sep 7, 2020
| formatted_results = [self._info_from_rule_status(rs) for rs in rule_statuses] | ||
| with open(self.filename, "w+") as output_file: | ||
| json.dump(formatted_results, output_file, indent=2) | ||
| print("Saved result to: {}".format(self.filename)) |
There was a problem hiding this comment.
Example result
[
{
"rule": "MokcRule",
"title": "title",
"messages": [
"msg1",
"msg2"
]
}
]
|
Ok, no idea how to make the test runnable on CI. Two days I had only py3.5 failing, know everything is cancelled... @potiuk any ideas? |
|
@mik-laj @kaxil @dimberman @ashb please take a look, the CI is green and I think we are good to merge it |
ashb
approved these changes
Sep 10, 2020
|
Thanks @ashb, I will just rebase the PR as I spotted the Dataproc HTTP commit here |
kaxil
reviewed
Sep 10, 2020
| @@ -337,7 +337,7 @@ def cancel(self, project_id, job_id, region='global'): | |||
| projectId=project_id, | |||
| region=region, | |||
| jobId=job_id | |||
| ) | |||
| ).execute(num_retries=self.num_retries) | |||
kaxil
approved these changes
Sep 10, 2020
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
turbaszek
force-pushed
the
upgrade-check-mvp-110
branch
from
6024b48
to
c9912bb
Compare
|
@turbaszek @mik-laj is this still a draft? Should I merge this into 1.10.13? |
|
@dimberman I think we should include to in "last" 1.10 release. Currently there's only one rule implemented so not a big gain |
turbaszek
added a commit
to PolideaInternal/airflow
that referenced
this pull request
Oct 21, 2020
Co-authored-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
turbaszek
pushed a commit
to PolideaInternal/airflow
that referenced
this pull request
Oct 23, 2020
Co-authored-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> (cherry picked from commit 2904810)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Co-authored-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> (cherry picked from commit 2904810)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a DRAFT and I still have to complete the missing documentation and unit tests.
I wanted to prepare a minimal valuable product for the upgrade_check command. Only one rule is implemented, but I think that's enough to show the feature. In the next steps, we can think about what rules we need to create, create tickets, and then work on the next rules by the whole community.
Recently, we have a lot of new beginner contributors and I think we can try to engage them for this task. Most rules will be small and independent, so they will be great candidates for good-first-issue.
An example of the result of this command is presented in the termianlshot below
Example JSON:
Part of: #8765
Continuation of the change, but for 1.10: #9276
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.