Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need of datetime.timezone in test_views.py #9479

Merged
merged 2 commits into from
Jun 23, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jun 22, 2020

datetime.timezone can be easily replaced by from airflow.utils.timezone


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

`datetime.timezone` can be easily replaced by `from airflow.utils.timezone`
@kaxil kaxil requested a review from ashb June 22, 2020 22:53
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jun 22, 2020
@kaxil kaxil merged commit 9997aff into apache:master Jun 23, 2020
@kaxil kaxil deleted the remove-need-of-tz branch June 23, 2020 21:27
kaxil added a commit to kaxil/airflow that referenced this pull request Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants