Fix encryption alert msg for env var, configuration->conf refactor #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2099,7 +2099,7 @@ def on_model_change(self, form, model, is_created): | |||
|
|
|||
| @classmethod | |||
| def alert_fernet_key(cls): | |||
| return not configuration.has_option('core', 'fernet_key') | |||
| return conf.get('core', 'fernet_key') is None | |||
There was a problem hiding this comment.
This is the actual fix, the rest is just search and replace
There was a problem hiding this comment.
Cool. I can help test it once you merge it, but looks good to the eye!
There was a problem hiding this comment.
This fix addresses the problem raised by the reporter in #920, but I've raised some concerns about how we are managing configuration in that issue, which we can fix by providing an easy way to inspect a unified view of the winning configuration in one place.
mistercrunch
added a commit
that referenced
this pull request
Feb 7, 2016
Fix encryption alert msg for env var, configuration->conf refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.