Increase typing coverage for Apache and http provider package #9729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
reviewed
Jul 8, 2020
There was a problem hiding this comment.
CI failed
airflow/providers/google/cloud/hooks/bigquery.py:83: error: Return type "BigQueryConnection" of "get_conn" incompatible with return type "None" in supertype "BaseHook"
airflow/providers/google/cloud/hooks/secret_manager.py:50: error: Return type "_SecretManagerClient" of "get_conn" incompatible with return type "None" in supertype "BaseHook"
mik-laj
reviewed
Jul 8, 2020
ephraimbuddy
commented
Jul 8, 2020
ephraimbuddy
commented
Jul 8, 2020
ephraimbuddy
changed the title
Co-authored-by: Kamil Breguła <mik-laj@users.noreply.github.com>
mik-laj
approved these changes
Jul 19, 2020
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about increasing typing coverage for the apache provider & http provider. Part of: #9708
I also worked on
apply_defaultsdecorator andBaseHookto help in more coverage.Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.