DbApiHook: Support kwargs in get_pandas_df #9730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Static check failed: Added kwargs in BigQueryHook as well |
|
Looks good @zikun -> but there is a handful of other hooks that are defining this method and (hive/exasol) - and by a quick look they could also benefit from those kwargs. Would you mind adding them there as well ? |
22quinn
force-pushed
the
DbApiHook-pandas-kwargs
branch
from
912d118
to
fa7192e
Compare
|
@potiuk Added to all the overriding methods |
turbaszek
reviewed
Aug 6, 2020
| @@ -106,7 +106,7 @@ def get_sqlalchemy_engine(self, engine_kwargs=None): | |||
| engine_kwargs = {} | |||
| return create_engine(self.get_uri(), **engine_kwargs) | |||
|
|
|||
| def get_pandas_df(self, sql, parameters=None): | |||
| def get_pandas_df(self, sql, parameters=None, **kwargs): | |||
There was a problem hiding this comment.
Would you mind adding information to method docstring?
22quinn
force-pushed
the
DbApiHook-pandas-kwargs
branch
from
d9d23d8
to
e47eeb9
Compare
turbaszek
approved these changes
Aug 6, 2020
|
@turbaszek let's merge it :) |
dimberman
pushed a commit
that referenced
this pull request
Sep 17, 2020
* DbApiHook: Support kwargs in get_pandas_df * BigQueryHook: Support kwargs in get_pandas_df * PrestoHook: Support kwargs in get_pandas_df * HiveServer2Hook: Support kwargs in get_pandas_df (cherry picked from commit 8f8db89)
RaviTezu
pushed a commit
to RaviTezu/airflow
that referenced
this pull request
Oct 25, 2020
* DbApiHook: Support kwargs in get_pandas_df * BigQueryHook: Support kwargs in get_pandas_df * PrestoHook: Support kwargs in get_pandas_df * HiveServer2Hook: Support kwargs in get_pandas_df (cherry picked from commit 8f8db89)
kaxil
pushed a commit
that referenced
this pull request
Nov 12, 2020
* DbApiHook: Support kwargs in get_pandas_df * BigQueryHook: Support kwargs in get_pandas_df * PrestoHook: Support kwargs in get_pandas_df * HiveServer2Hook: Support kwargs in get_pandas_df (cherry picked from commit 8f8db89)
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
* DbApiHook: Support kwargs in get_pandas_df * BigQueryHook: Support kwargs in get_pandas_df * PrestoHook: Support kwargs in get_pandas_df * HiveServer2Hook: Support kwargs in get_pandas_df (cherry picked from commit 8f8db89)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
* DbApiHook: Support kwargs in get_pandas_df * BigQueryHook: Support kwargs in get_pandas_df * PrestoHook: Support kwargs in get_pandas_df * HiveServer2Hook: Support kwargs in get_pandas_df (cherry picked from commit 8f8db89)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support all parameters that are supported by pandas
read_sqlfunction: https://github.com/pandas-dev/pandas/blob/1.0.x/pandas/io/sql.py#L336-L345Closes #8468
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.