[AMBARI-23652] LogFeeder: lowercase cluster name (writing solr docs & znode generation) #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
oleewere
changed the title
kasakrisz
approved these changes
Apr 23, 2018
adoroszlai
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Lowercase cluster name for logfeeder (cluster name is lowercase in solr anyway), it's required as logfeeder will create the cluster znode with the cluster name, and if it is with uppercase we cannot get the right logs with cluster filter
for now, if its not set, null string will be used
How was this patch tested?
manually with docker-env
please review @swagle @miklosgergely @kasakrisz @adoroszlai