Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-23683] dfs_ha_initial_* properties should be removed after installation #1094

Merged
merged 3 commits into from Apr 26, 2018

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Some temporary properties required for blueprint-based provisioning of NameNode HA setup may cause problems later (eg. during upgrade).

This change proposes:

  1. a listener that removes these properties (eg. dfs_ha_initial_namenode_active) when blueprint-based cluster provisioning finished successfully
  2. to avoid the need to restart all HDFS components, the properties need to be added to cluster-env instead of hadoop-env
  3. for backward compatibility, move any such property specified in hadoop-env in the blueprint to cluster-env during provisioning

How was this patch tested?

Deployed clusters via blueprint using the following scenarios:

  • NN HA with Ambari-generated properties
  • NN HA with user-specified properties in hadoop-env
  • single NN

Verified that the removed properties are not sent in subsequent commands (eg. service check).

@adoroszlai adoroszlai self-assigned this Apr 25, 2018
@asfgit
Copy link

asfgit commented Apr 25, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1985/
Test FAILed.
Test FAILured.

@asfgit
Copy link

asfgit commented Apr 25, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1992/
Test FAILed.
Test FAILured.

@asfgit
Copy link

asfgit commented Apr 26, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1998/
Test PASSed.

Copy link
Contributor

@rnettleton rnettleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks fine to me.

@adoroszlai adoroszlai merged commit 1e15cda into apache:trunk Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants