[AMBARI-23897] Log Search UI: login with invalid password – no error message is displayed #1337
Conversation
…message is displayed
|
Refer to this link for build results (access rights to CI server needed): |
| this.setLoginInProgressAppState(true); | ||
| const response$ = this.httpClient.postFormData('login', { | ||
| username: username, | ||
| password: password | ||
| }); | ||
| }).share(); |
There was a problem hiding this comment.
Would be better to add share() globally for all requests (request() method of HttpClientService). It used to be implemented in such a way some time ago. Any reason why this attempt doesn't fit? share() was removed in scope of AMBARI-23514
| logout(): Observable<Response> { | ||
| const response$ = this.httpClient.get('logout'); | ||
| logout(): Observable<Boolean> { | ||
| const response$ = this.httpClient.get('logout').share(); |
There was a problem hiding this comment.
See comment for line 84, the same here
| @@ -16,7 +16,7 @@ | |||
| --> | |||
|
|
|||
| <div class="login-form well col-md-4 col-md-offset-4 col-sm-offset-4"> | |||
| <div class="alert alert-danger" *ngIf="isLoginAlertDisplayed" [innerHTML]="'authorization.error' | translate"></div> | |||
| <div class="alert alert-danger" *ngIf="isLoginAlertDisplayed" [innerHTML]="errorMessage"></div> | |||
There was a problem hiding this comment.
No need to use innerHTML attribute since there are no more HTML tags in the message
| @@ -219,6 +219,8 @@ | |||
| "logIndexFilter.update.error": "Error at updating Log Index Filter for cluster <span class='cluster-name'>{{cluster}}</span>. {{message}}", | |||
|
|
|||
| "login.title": "Login", | |||
| "login.error.title": "Login error", | |||
There was a problem hiding this comment.
"authorization.error" prop can be removed
…message is displayed
|
Refer to this link for build results (access rights to CI server needed): |
What changes were proposed in this pull request?
Added error message when the auth service trigger auth error. To do this correctly I changed the auth service slightly. Also I simplified the unit test of the login component.
How was this patch tested?
Tested manually and with unit tests (267/267 success)
Please review Ambari Contributing Guide before opening a pull request.
@aBabiichuk please review it. Thanks.