Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMBARI-23929] Stack changes for AMS to help with HDP 2.6 to 3.0 EU (dsen) #1353

Merged
merged 2 commits into from May 30, 2018
Merged

[AMBARI-23929] Stack changes for AMS to help with HDP 2.6 to 3.0 EU (dsen) #1353

merged 2 commits into from May 30, 2018

Conversation

d0zen1
Copy link
Contributor

@d0zen1 d0zen1 commented May 22, 2018

What changes were proposed in this pull request?

Added sink version check before hadoop services start

How was this patch tested?

manually

@d0zen1 d0zen1 requested review from swagle and avijayanhwx May 22, 2018 13:25
@asfgit
Copy link

asfgit commented May 22, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2413/
Test PASSed.

@avijayanhwx avijayanhwx requested a review from aonishuk May 23, 2018 23:01
avijayanhwx
avijayanhwx suggested changes May 23, 2018
View reviewed changes
Copy link

@avijayanhwx avijayanhwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes need to go into common-services/AMBARI_METRICS startup scripts also.

avijayanhwx
avijayanhwx reviewed May 23, 2018
View reviewed changes
ambari-common/src/main/python/ambari_commons/repo_manager/yum_manager.py
@@ -63,7 +63,7 @@ class YumManagerProperties(GenericManagerProperties):
}

verify_dependency_cmd = [repo_manager_bin, '-d', '0', '-e', '0', 'check', 'dependencies']
installed_package_version_command = [pkg_manager_bin, "-q", "--queryformat", "%{{version}}-%{{release}}"]
installed_package_version_command = [pkg_manager_bin, "-q", "--queryformat", "%{version}-%{release}\n"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes only yum manager. Can we check if this change is needed in other OS families also?

@avijayanhwx
Copy link

Based on trying this out on different OS families, here are my findings

  • RHEL
    The modified command in your patch works.

  • SLES
    The modified command in your patch works. So, the code change needs to be done in ambari-common/src/main/python/ambari_commons/repo_manager/zypper_manager.py as well. Also, the rpm bin location was /bin/rpm instead of the /usr/bin/rpm as present in the code.

  • Debian & Ubuntu
    The current dpkg command works, but the package name should be changed to 'ambari-metrics-assembly'.

@asfgit
Copy link

asfgit commented May 29, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2487/
Test PASSed.

@avijayanhwx avijayanhwx mentioned this pull request May 29, 2018
Merged
@d0zen1 d0zen1 merged commit d447ea5 into apache:trunk May 30, 2018
@d0zen1 d0zen1 deleted the AMBARI-23929-trunk branch May 30, 2018 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avijayanhwx avijayanhwx avijayanhwx approved these changes

@swagle swagle Awaiting requested review from swagle

@aonishuk aonishuk Awaiting requested review from aonishuk

Assignees

@d0zen1 d0zen1

Labels
ambari-metrics
Projects
None yet
Milestone
No milestone
3 participants
@d0zen1 @asfgit @avijayanhwx