-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMBARI-22795] LogSearch Fixes for LogList Display #137
Conversation
Added two layout: table and flexible. The table layout is good for comparison, when we need to have the same column width. The flexible layout is good for searching information. In the flexible layout you can turn on or of the labels. The default is the table layout. White spaces were removed from the first two columns. The text overflow ellipsis fixed. The sub menu icon has been changed to vertical one.
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- triggering Copy and Open context actions results in their labels added to the table content
- getLabelForField looks weird since labels are already defined in columns property, and this method fails on 'Row type' column
- recently implemented context-menu component is rolled back to and old approach
Added two layout: table and flexible. The table layout is good for comparison, when we need to have the same column width. The flexible layout is good for searching information. In the flexible layout you can turn on or of the labels. The default is the table layout. White spaces were removed from the first two columns. The text overflow ellipsis fixed. The sub menu icon has been changed to vertical one.
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
retest this please |
Refer to this link for build results (access rights to CI server needed): |
What changes were proposed in this pull request?
Added two layout: table and flexible. The table layout is good for comparison, when we need to have the same column width. The flexible layout is good for searching information. In the flexible layout you can turn on or off the labels.
The default is the table layout.
White spaces were removed from the first two columns.
The text overflow ellipsis fixed.
The sub menu icon has been changed to vertical one.
How was this patch tested?
unit tests, manual tests
Please review this @aBabiichuk.