Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-22795] LogSearch Fixes for LogList Display #137

Merged
merged 4 commits into from
Jan 19, 2018

Conversation

tobias-istvan
Copy link
Member

What changes were proposed in this pull request?

Added two layout: table and flexible. The table layout is good for comparison, when we need to have the same column width. The flexible layout is good for searching information. In the flexible layout you can turn on or off the labels.
The default is the table layout.

White spaces were removed from the first two columns.
The text overflow ellipsis fixed.
The sub menu icon has been changed to vertical one.

How was this patch tested?

unit tests, manual tests

screen shot 2018-01-18 at 0 24 14

Please review this @aBabiichuk.

Added two layout: table and flexible. The table layout is good for comparison, when we need to have the same column width. The flexible layout is good for searching information. In the flexible layout you can turn on or of the labels.
The default is the table layout.

White spaces were removed from the first two columns.
The text overflow ellipsis fixed.
The sub menu icon has been changed to vertical one.
@asfgit
Copy link

asfgit commented Jan 18, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/173/
Test FAILed.
Test FAILured.

Copy link
Contributor

@aBabiichuk aBabiichuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. triggering Copy and Open context actions results in their labels added to the table content
  2. getLabelForField looks weird since labels are already defined in columns property, and this method fails on 'Row type' column
  3. recently implemented context-menu component is rolled back to and old approach

Added two layout: table and flexible. The table layout is good for comparison, when we need to have the same column width. The flexible layout is good for searching information. In the flexible layout you can turn on or of the labels.
The default is the table layout.

White spaces were removed from the first two columns.
The text overflow ellipsis fixed.
The sub menu icon has been changed to vertical one.
@asfgit
Copy link

asfgit commented Jan 18, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/180/
Test FAILed.
Test FAILured.

@asfgit
Copy link

asfgit commented Jan 18, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/182/
Test FAILed.
Test FAILured.

@vivekratnavel vivekratnavel changed the title AMBARI-22795 [AMBARI-22795] LogSearch Fixes for LogList Display Jan 18, 2018
@asfgit
Copy link

asfgit commented Jan 18, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/187/
Test FAILed.
Test FAILured.

@aBabiichuk
Copy link
Contributor

retest this please

@asfgit
Copy link

asfgit commented Jan 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/195/
Test PASSed.

@aBabiichuk aBabiichuk merged commit b0b6106 into apache:trunk Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants