AMBARI-24040. Infra Solr start/stop should be idempotent. #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagle
approved these changes
Jun 5, 2018
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
kasakrisz
approved these changes
Jun 6, 2018
adoroszlai
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I can send a START or STOP batch command with the Rest API to Infra Solr (which is already running, or already stopped), in that case the START command could fail. (STOP is not, but i can call solr stop directly without the condition as it returs with exit code 0 if the process is already running, it is even checking the process status if the pid file does not exist by grepping the used jetty port)
How was this patch tested?
UTs passed
Please review @adoroszlai @g-boros @kasakrisz @swagle